Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for branch convergence #18

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

Update for branch convergence #18

wants to merge 82 commits into from

Conversation

vonHartz
Copy link
Contributor

@vonHartz vonHartz commented Oct 20, 2021 •
edited
Loading

For some additional details see discussion below.

Updates:

  • some autoformatting
  • added some mujoco-envs (walker2d, humanoid)
  • logging ray.init-kwargs
  • external ray init option
  • wandb logging option
  • patch for missing seq_len key: using default of 1
  • added generic env_wrapper
  • switched from dill to cloudpickle for saving ray analysis
  • added kwargs for ray init to arg parse
  • also returning stats_file name now
  • docs building, including doc of CLI options

@vonHartz
test ignoring docs again
61c4439
@vonHartz
ignore build
0912f8a
@vonHartz
added exec flag
e595120
@vonHartz
rebuilt docs
3795d3a
@vonHartz
also ignore autosummary, .
4e43fc2
@vonHartz
removed compiled autosummary
25cfabe
@vonHartz
made agnostics to sys lang/locale"
f9a3094
@vonHartz
made agnostics to sys lang/locale
6905088
@vonHartz
replaced sed with awk
e3af590
@vonHartz
Merge branch 'dev/jan' of github.com:automl/mdp-playground into dev/jan
7ba4101
@vonHartz
Merge branch 'master' into dev/jan
3e3fcb7
@vonHartz
re-added toml
c719e94
@vonHartz
changed comparison style
17add47
@vonHartz
updated pub docs instructions
e394d1c
@vonHartz
Merge branch 'master' into dev/jan
97ac65c
@vonHartz
fixed merge
31b485a
@vonHartz
updated deps
9d452a4
@vonHartz
generic gym wrapper registration, automatic pep8, updates
9de56ff
@vonHartz
resolved merge
c8dab2e
@vonHartz
rebuilt lock
b3217a4
@vonHartz
removed debug artifcats
acf4f19
@vonHartz
removed debug artifacts
e791232
@vonHartz
fixed gym make
7e68284
@vonHartz
additional mujoco env wrapper registration
c4f2b95
@vonHartz
fixed env import
9a1a7d6
@vonHartz
log ray init args for debugging
5c30a76
@vonHartz
trying to always run in local Mode (might crash SAC -> verify) to fix…
7291caf 
… DQN_1 crash
@vonHartz
hotfix formissing sequence_length key when using lstm model
c974ddb
@vonHartz
modified lstm patch to aboid dict size change during iteration
b7e2df6
@vonHartz
need to patch in outer loop
06aac8f
@codecov
Copy link

codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #18 (2fb747d) into master (bfe2ea3) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   72.66%   72.33%   -0.33%     
==========================================
  Files          30       30              
  Lines        3698     3745      +47     
==========================================
+ Hits         2687     2709      +22     
- Misses       1011     1036      +25
Flag Coverage Δ
unittests 72.33% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdp_playground/analysis/analysis.py 26.94% <ø> (ø)
...dp_playground/config_processor/config_processor.py 45.63% <ø> (-1.05%) ⬇️
mdp_playground/scripts/run_experiments.py 85.22% <ø> (-5.69%) ⬇️
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe2ea3...2fb747d. Read the comment docs.

vonHartz
vonHartz commented Oct 20, 2021
View reviewed changes
Copy link
Contributor Author

@vonHartz vonHartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts.

mdp_playground/scripts/run_experiments.py Outdated Show resolved Hide resolved
mdp_playground/scripts/run_experiments.py Show resolved Hide resolved
mdp_playground/scripts/run_experiments.py Outdated Show resolved Hide resolved
vonHartz
vonHartz commented Oct 20, 2021
View reviewed changes
Copy link
Contributor Author

@vonHartz vonHartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code selection.

vonHartz
vonHartz commented Oct 22, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@vonHartz
Copy link
Contributor Author

All requested changes made. Ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghuSpaceRajan RaghuSpaceRajan Awaiting requested review from RaghuSpaceRajan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vonHartz